test(forkJoin): add tests with never and with unsubscribing after error #2394
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benlesh
requested changes
Feb 20, 2017
spec/observables/forkJoin-spec.ts
Outdated
| hot('------#'), | ||
| hot('----------')); | ||
| const expected = '------#'; | ||
|
|
There was a problem hiding this comment.
Can we vertically align these marble strings? It's good to make the next developer see the visual alignment of the events.
spec/observables/forkJoin-spec.ts
Outdated
| hot('--------------'), | ||
| hot('------|') | ||
| ); | ||
| const expected = '------|'; |
There was a problem hiding this comment.
Same as the other feedback... vertically align the marbles.
Add tests with Observable that never completes, so that it is clear how forkJoin operator behaves with it. Add test which shows that forkJoin unsubscribes from other Observables when one of them errors.
|
@Blesh done. |
benlesh
approved these changes
Apr 3, 2017
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
I am writing docs for
forkJoinand felt bad making assertions about how it behaves, without having unit tests to back me up.